Revert "fix(gix-index): handle loongarch64-musl stat struct field names"#2455
Revert "fix(gix-index): handle loongarch64-musl stat struct field names"#2455Byron merged 1 commit intoGitoxideLabs:mainfrom
Conversation
This reverts commit 7e25c34. The issue was fixed in libc: rust-lang/libc#4958
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: afe154c375
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| target_os = "hurd", | ||
| all(target_arch = "loongarch64", target_env = "musl") | ||
| )))] | ||
| #[cfg(not(any(target_os = "aix", target_os = "hurd")))] |
There was a problem hiding this comment.
This revert drops the loongarch64-musl branch from the cfg guard, so that target now compiles against self.0.st_mtime/st_mtime_nsec again; with libc = "0.2.180" still allowed in gix-index/Cargo.toml (line 60), that reintroduces the same build failure fixed in 7e25c34 because stat exposes st_mtim/st_ctim fields there. In practice, any consumer or lockfile still on libc 0.2.180 and building loongarch64-unknown-linux-musl will fail to compile this crate unless they manually bump libc.
Useful? React with 👍 / 👎.
|
Sorry for the long wait, and thanks @weihanglo for your appearance. That helped me to prioritise. |
|
Will this change appear as intended in the changelog, or should something else be done to achieve that? I don't think cargo-smart-release recognizes commit messages of the form |
4 participants
This reverts commit 7e25c34.
The issue was fixed in libc: rust-lang/libc#4958